Skip to content

Commit 983a16a

Browse files
committed
Add class for last commit
This can't be selected, because there are no commits after it.
1 parent 0691283 commit 983a16a

File tree

2 files changed

+17
-14
lines changed

2 files changed

+17
-14
lines changed

gitique.css

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
}
1818

1919
.gitique-icon.gitique-initial {
20-
color: #bbb;
20+
color: #bdbdbd;
2121
}
2222

2323
.gitique-icon.gitique-reviewed {
@@ -32,7 +32,11 @@
3232
color: #6cc644;
3333
}
3434

35-
.gitique-icon.gitique-clickable {
35+
.gitique-icon.gitique-head {
36+
color: #48a220;
37+
}
38+
39+
.gitique-icon:not(.gitique-initial):not(.gitique-head) {
3640
cursor: pointer;
3741
}
3842

src/gitique/core.cljs

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,9 @@
127127
(.insertBefore parent group sibling)))
128128

129129
(defn- reset-classes! []
130-
(doseq [class ["gitique-hidden" "gitique-context"]]
131-
(doseq [element (util/qsa (str "." class))]
132-
(util/remove-class element class))))
130+
(let [classes ["gitique-hidden" "gitique-context"]]
131+
(doseq [element (util/qsa (string/join ", " (map #(str "." %) classes)))]
132+
(apply util/remove-class element classes))))
133133

134134
(defn- annotate-lines! [element file]
135135
(let [new-lines-list (flatten (:new (-> file :patch pure/parse-diff)))
@@ -154,20 +154,20 @@
154154
(defn- select-commit [event]
155155
(swap! state assoc :selected-commit (commit-sha (.-parentElement (.-target event)))))
156156

157-
(defn- add-icon! [element clickable]
157+
(defn- add-icon! [element override-class]
158158
(let [parent (.-parentElement (.-parentElement element))]
159159
(when-not (util/qs ".gitique-icon" parent)
160160
(let [icon (dom/createDom "span" #js["octicon octicon-diff-added gitique-icon"])]
161-
(when clickable
162-
(.addEventListener icon "click" select-commit)
163-
(util/add-class icon "gitique-clickable"))
161+
(if override-class
162+
(util/add-class icon override-class)
163+
(.addEventListener icon "click" select-commit))
164164
(.appendChild parent icon)))))
165165

166166
(defn- add-icons! []
167167
(let [elements (util/qsa ".commit-id")]
168-
(doseq [element (rest (butlast elements))] (add-icon! element true))
169-
(when-let [first (first elements)] (add-icon! first false))
170-
(when-let [last (last elements)] (add-icon! last false))))
168+
(doseq [element (rest (butlast elements))] (add-icon! element nil))
169+
(when-let [first (first elements)] (add-icon! first "gitique-initial"))
170+
(when-let [last (last elements)] (add-icon! last "gitique-head"))))
171171

172172
(defn- find-commit
173173
"Find the link to a commit on the page by its SHA"
@@ -178,8 +178,7 @@
178178
(let [element (if (string? commit-id)
179179
(util/qs ".gitique-icon" (find-commit commit-id))
180180
commit-id)]
181-
(doseq [class ["gitique-initial" "gitique-reviewed" "gitique-basis" "gitique-new"]]
182-
(util/remove-class element class))
181+
(util/remove-class element "gitique-initial" "gitique-reviewed" "gitique-basis" "gitique-new")
183182
(util/add-class element new-class)
184183
(.setAttribute element "title" new-title)))
185184

0 commit comments

Comments
 (0)