Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing cloud name to Cloudex.Url.for/2? #29

Open
nathanl opened this issue Sep 15, 2017 · 3 comments
Open

Allow passing cloud name to Cloudex.Url.for/2? #29

nathanl opened this issue Sep 15, 2017 · 3 comments

Comments

@nathanl
Copy link
Contributor

nathanl commented Sep 15, 2017

Great library, thanks! 👍 😄

Would you consider a PR to accept the cloud name as a parameter to Cloudex.Url.for/2, leaving the configured value as the default?

I'm currently working around not having this by replacing the cloud name in the returned URL.

    [start, rest] = Regex.split(
      ~r/(http|https):\/\/res.cloudinary.com\/(?<cloud_name>\w+)\/.*/,
      url, on: [:cloud_name]
    )
    Enum.join([start, desired_cloud_name, rest])
@smeevil
Copy link
Owner

smeevil commented Sep 19, 2017

Hi,

Sorry for the slow response, slipped my mind :/
Yes, a PR to override the cloud name would be fine :)

Gerard.

@smeevil
Copy link
Owner

smeevil commented Oct 16, 2017

Hi @nathanl,

Wondering if this is still something you would like to change or need ?

Gerard.

@nathanl
Copy link
Contributor Author

nathanl commented Oct 16, 2017

It's not an urgent need - we're working around it right now. I just haven't gotten around to making a PR yet. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants