Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts on upload can't be configured #71

Open
sevenseacat opened this issue Nov 3, 2020 · 1 comment · May be fixed by #72
Open

Timeouts on upload can't be configured #71

sevenseacat opened this issue Nov 3, 2020 · 1 comment · May be fixed by #72

Comments

@sevenseacat
Copy link

sevenseacat commented Nov 3, 2020

Currently the duration for an upload request is limited to hackney's default, which is 5 seconds. This means we're seeing a lot of timeouts for uploading large images (or running a dev server on not-the-world's-best-internet).

This code:
https://github.com/smeevil/cloudex/blob/master/lib/cloudex.ex#L33
looks like it should set it to 60 seconds, but it doesn't.

The timeout can be manually overridden by adding timeout and/or recv_timeout options here:
https://github.com/smeevil/cloudex/blob/master/lib/cloudex/cloudinary_api.ex#L116-L122
But ideally should be configurable from the calling application.

I suspect this will also affect any of the other API operations that have the manual 60-second Task.await call.

@travelmassive
Copy link

I agree - this would be very helpful. 5 seconds isn't long enough. Hopefully the author can accept the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants