Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation notice with PHP 8.1.5 #169

Closed
givanov2 opened this issue Jun 14, 2022 · 3 comments
Closed

Deprecation notice with PHP 8.1.5 #169

givanov2 opened this issue Jun 14, 2022 · 3 comments

Comments

@givanov2
Copy link

Hello, thank you for the excellent library.

FYI, when using ClickHouseDB\Client::write with PHP 8.1.5, the following notice appears:

Deprecated: Return type of ClickHouseDB\Statement::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /.../vendor/smi2/phpclickhouse/src/Statement.php on line 581

PHP information:

PHP 8.1.5 (cli) (built: Apr 18 2022 23:52:55) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.5, Copyright (c) Zend Technologies
@m1khal3v
Copy link

Fixed here #170

@isublimity
Copy link
Contributor

Fixed here #170

Thx! Release in 1.4.6

@givanov2
Copy link
Author

Hello. Any chance this change gets in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isublimity @givanov2 @m1khal3v