Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing assumptions #50

Open
elwazana opened this issue Jun 4, 2018 · 3 comments
Open

Missing assumptions #50

elwazana opened this issue Jun 4, 2018 · 3 comments
Assignees

Comments

@elwazana
Copy link
Collaborator

elwazana commented Jun 4, 2018

swhs/SRS/PCM_SRS.tex

Lines 951 to 958 in 0fa29b3

Description &
${q_{P}}$ is the heat flux into the PCM from water
($\frac{\text{W}}{\text{m}^{2}}$)\newline${h_{P}}$ is the
convective heat transfer coefficient between PCM and water
($\frac{\text{W}}{(\text{m}^{2}{}^{\circ}C)}$)\newline${T_{W}}$ is
the temperature of the water (${}^{\circ}C$)\newline$t$ is the
time (s)\newline${T_{P}}$ is the temperature of the phase change
material (${}^{\circ}C$) % what happened to the assumptions? [SS]

See Dr. Smith's comment in issue #33

@elwazana elwazana assigned smiths and elwazana and unassigned smiths Jun 4, 2018
@smiths
Copy link
Owner

smiths commented Jun 5, 2018

@elwazana update the manual version to reintroduce the missing information. We'll have to make corresponding changes to the Drasil version.

@elwazana
Copy link
Collaborator Author

elwazana commented Jun 5, 2018

@smiths I forgot to ask during the meeting, but do you mean to just reset the changes that removed the assumptions, and other information? Or should I also add Ap to the description like we discussed?

Also, should I do these changes in a branch and create a PR for it so you can review them before they get fully incorporated?

@smiths
Copy link
Owner

smiths commented Jun 8, 2018

@elwazana, I'm surprised you are asking. I thought I repeated the point so many times that I was boring everyone in the room. 😄 We do not want to lose ANY information. The removed assumptions are critical information. Your original question about Ap triggered the discovery of other important information that was deleted. I want ALL THE KNOWLEDGE that was deleted added back.

You do not need to worry about a pull request. The Case Studies repo is not as delicate as the Drasil repo, since your changes will only impact this one example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants