-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host a non-#[doc(hidden)]
Rust documentation for contributors
#1778
Comments
Personally, I'd rather direct contributors to build the docs themselves using those options. I do agree that being able to find broken doc links would be beneficial. |
We no longer do this since it turns out the semver constraints are still there even with doc hidden. Going to resolve this since docs can also be built locally. |
We use
#[doc(hidden)]
extensively in therust-runtime
crates to allow for APIs to be public to the code generated code but not public to the general consumer to avoid semver constraints - if somethings#[doc(hidden)]
we can change its API without the risk of breaking customer code.This poses a problem for writing documentation for contributors however - docs are not able to point a link to a hosted document which contains API descriptions.
Compiling our own documentation in CI using
and then hosting it would remedy this.
In both the hidden and unhidden cases, having a link to the hosted documentation in the README.md would be beneficial.
As an additional side effect, we would also be able to catch broken doc links, lints, etc in CI. Running
cargo doc
inrust-runtime
reveals 3 lints, runningRUSTDOCFLAGS='-Z unstable-options --document-hidden-items' cargo +nightly doc
reveals 50+.The text was updated successfully, but these errors were encountered: