Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport AddExtensionLayer type from tower_http in server generated crates #2556

Open
paulnice opened this issue Apr 7, 2023 · 0 comments
Open
Labels

Comments

@paulnice
Copy link

paulnice commented Apr 7, 2023

Please reexport tower_http structures used in server generate crates as parts of the crates.

Recent updates in aws-smithy-http-server = 0.55 broke our code which directly imported aws-smithy-http-server = 0.54.4 and transitively import aws-smithy-http-server = 0.55 as part of server generated crate. The solution was to use the server generated imports of aws-smithy-http-server introduced in #1909.

But while doing a fix I found that AddExtensionLayer from tower_http is not reexported in the server generated crate and has a chance to broke our code again, because now I have to import tower_http directly in my Cargo.toml, instead of importing from aws-smithy-http-server.

@jdisanti jdisanti added server Rust server SDK customer-request labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants