Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle name collisions for unknown variants #386

Closed
1 of 4 tasks
ghost opened this issue May 17, 2021 · 1 comment · Fixed by #818
Closed
1 of 4 tasks

Handle name collisions for unknown variants #386

ghost opened this issue May 17, 2021 · 1 comment · Fixed by #818
Labels
production-readiness tracking Meta-issues to track overall progress

Comments

@ghost
Copy link

ghost commented May 17, 2021

Handle cases where there can be a collision between a name in a service model and the generated Unhandled/Unknown variants in:

  • .send() function on fluent builders (triggered by a member named "send")
  • Unhandled variant on errors
  • Unknown variant on unions
  • Unknown variant on enums
@rcoh rcoh added the tracking Meta-issues to track overall progress label May 17, 2021
@rcoh
Copy link
Collaborator

rcoh commented May 17, 2021

we have a "naming obstacle course model"—we can add all of these cases to it as a long-term regression test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
production-readiness tracking Meta-issues to track overall progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants