shorten internal serde fn names

Author: kuhe

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java

@@ -448,8 +448,8 @@ private void writeSerdeDispatcher(boolean isInput) {
             writer.write("throw new Error(\"No supported protocol was found\");");
         } else {
             String serdeFunctionName = isInput
-                    ? ProtocolGenerator.getSerFunctionName(symbol, protocolGenerator.getName())
-                    : ProtocolGenerator.getDeserFunctionName(symbol, protocolGenerator.getName());
+                    ? ProtocolGenerator.getSerFunctionShortName(symbol)
+                    : ProtocolGenerator.getDeserFunctionShortName(symbol);
             writer.addImport(serdeFunctionName, serdeFunctionName,
                     Paths.get(".", CodegenUtils.SOURCE_FOLDER, ProtocolGenerator.PROTOCOLS_FOLDER,
                             ProtocolGenerator.getSanitizedName(protocolGenerator.getName())).toString());

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServerCommandGenerator.java

@@ -163,8 +163,8 @@ private void writeOperationSerializer() {
         writer.addImport("OperationSerializer", "__OperationSerializer", "@aws-smithy/server-common");
         writer.openBlock("export class $L implements __OperationSerializer<$T<any>, $S, $T> {", "}",
                 serializerName, serverSymbol, operationSymbol.getName(), errorsType, () -> {
-            String serializerFunction = ProtocolGenerator.getGenericSerFunctionName(operationSymbol) + "Response";
-            String deserializerFunction = ProtocolGenerator.getGenericDeserFunctionName(operationSymbol) + "Request";
+            String serializerFunction = ProtocolGenerator.getGenericSerFunctionName(operationSymbol) + "Res";
+            String deserializerFunction = ProtocolGenerator.getGenericDeserFunctionName(operationSymbol) + "Req";
 
             writer.addImport(serializerFunction, null,
                 Paths.get(".", CodegenUtils.SOURCE_FOLDER, ProtocolGenerator.PROTOCOLS_FOLDER,

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/DocumentMemberDeserVisitor.java

@@ -48,20 +48,23 @@
 import software.amazon.smithy.utils.SmithyUnstableApi;
 
 /**
- * Visitor to generate member values for aggregate types deserialized from documents.
+ * Visitor to generate member values for aggregate types deserialized from
+ * documents.
  *
  * The standard implementations are as follows; these implementations may be
  * overridden unless otherwise specified.
  *
  * <ul>
- *   <li>Blob: base64 decoded.</li>
- *   <li>BigInteger: converted to JS BigInt.</li>
- *   <li>BigDecimal: converted to Big via {@code big.js}.</li>
- *   <li>Timestamp: converted to JS Date.</li>
- *   <li>Service, Operation, Resource, Member: not deserializable from documents. <b>Not overridable.</b></li>
- *   <li>Document, List, Map, Set, Structure, Union: delegated to a deserialization function.
- *     <b>Not overridable.</b></li>
- *   <li>All other types: unmodified.</li>
+ * <li>Blob: base64 decoded.</li>
+ * <li>BigInteger: converted to JS BigInt.</li>
+ * <li>BigDecimal: converted to Big via {@code big.js}.</li>
+ * <li>Timestamp: converted to JS Date.</li>
+ * <li>Service, Operation, Resource, Member: not deserializable from documents.
+ * <b>Not overridable.</b></li>
+ * <li>Document, List, Map, Set, Structure, Union: delegated to a
+ * deserialization function.
+ * <b>Not overridable.</b></li>
+ * <li>All other types: unmodified.</li>
  * </ul>
  */
 @SmithyUnstableApi
@@ -73,32 +76,34 @@ public class DocumentMemberDeserVisitor implements ShapeVisitor<String> {
     /**
      * Constructor.
      *
-     * @param context The generation context.
-     * @param dataSource The in-code location of the data to provide an output of
-     *                   ({@code output.foo}, {@code entry}, etc.)
+     * @param context                The generation context.
+     * @param dataSource             The in-code location of the data to provide an
+     *                               output of
+     *                               ({@code output.foo}, {@code entry}, etc.)
      * @param defaultTimestampFormat The default timestamp format used in absence
      *                               of a TimestampFormat trait.
      */
     public DocumentMemberDeserVisitor(
             GenerationContext context,
             String dataSource,
-            Format defaultTimestampFormat
-    ) {
+            Format defaultTimestampFormat) {
         this.context = context;
         this.dataSource = dataSource;
         this.defaultTimestampFormat = defaultTimestampFormat;
     }
 
     /**
-     * @return the member this visitor is being run against. Used to discover member-applied
-     * traits, such as @timestampFormat. Can be, and defaults, to, null.
+     * @return the member this visitor is being run against. Used to discover
+     *         member-applied
+     *         traits, such as @timestampFormat. Can be, and defaults, to, null.
      */
     protected MemberShape getMemberShape() {
         return null;
     }
 
     /**
-     * @return true if string-formatted epoch seconds in payloads are disallowed. Defaults to false.
+     * @return true if string-formatted epoch seconds in payloads are disallowed.
+     *         Defaults to false.
      */
     protected boolean requiresNumericEpochSecondsInPayload() {
         return false;
@@ -283,7 +288,7 @@ private String getDelegateDeserializer(Shape shape) {
     private String getDelegateDeserializer(Shape shape, String customDataSource) {
         // Use the shape for the function name.
         Symbol symbol = context.getSymbolProvider().toSymbol(shape);
-        return ProtocolGenerator.getDeserFunctionName(symbol, context.getProtocolName())
+        return ProtocolGenerator.getDeserFunctionShortName(symbol)
                 + "(" + customDataSource + ", context)";
     }
 }

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/integration/DocumentMemberSerVisitor.java

@@ -252,7 +252,7 @@ public final String unionShape(UnionShape shape) {
     private String getDelegateSerializer(Shape shape) {
         // Use the shape for the function name.
         Symbol symbol = context.getSymbolProvider().toSymbol(shape);
-        return ProtocolGenerator.getSerFunctionName(symbol, context.getProtocolName())
+        return ProtocolGenerator.getSerFunctionShortName(symbol)
                 + "(" + dataSource + ", context)";
     }
 }