-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: do not cut values on the stack #179
Comments
Personally, I like the current behavior, but if other users feel strongly on it please speak up here; WDYT @thevaizman |
From an aesthetic POV I'm with @dorlevi on this one, even though I understand @elawbek's point that the values shown do not replicate how they're really stored on the stack. Having said that, if there's a large demand from the community, we should go with them :) |
If you add a flag to show or not show the full size of the stack value? I just don't know how to check if there is a demand from the community. |
I don't expect you to go and gauge it, I think we can leave it as an improvement here and see if some other frequent users voice in, I wouldn't want to add a flag in, less code is better here, but I am interested to better understand your motivation and maybe we should do what you propose and not truncate it. When you say "more convenient" what do you mean? I personally believe that it's more convenient to trim/truncate the values as it's a clearer UXand (assume) that a user that got to the playground and investigated the stack assumes that it's truncated, I didn't expect people to copy-paste/use these values other than just exploring in the tool thanks again |
As a frequent user, I am used to the fact that when
there is just the number 42 in the stack, but in the memory is shifted and the number is actually written not to the first byte but to the 32nd (I understand that by definition That's all. If you think these reasons aren't enough, let me know. |
I agree with @elawbek that its interesting feature and I'd like to see real view of variables in stack. |
I agree with @elawbek there should be a way to toggle between aesthetic and actual view. |
I think it would be more convenient if the values in the stack will not be truncated, e.g.
PUSH1 0x42
would output in stack not just42
but0000000000000000000000000000000000000000000000000000000000000042
, i.e. with a size of 32 bytes.If my suggestion does not suit you, let me know.
The text was updated successfully, but these errors were encountered: