Skip to content

Seal CommandExt #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
taiki-e opened this issue Dec 29, 2020 · 0 comments · Fixed by #32
Closed

Seal CommandExt #6

taiki-e opened this issue Dec 29, 2020 · 0 comments · Fixed by #32

Comments

@taiki-e
Copy link
Collaborator

taiki-e commented Dec 29, 2020 •
edited
Loading

Both unix::CommandExt and windows::CommandExt are not intended to be implemented by users, and they should be sealed.

Note that this is a breaking change. (However, given the standard library added a new method in the minor version to os-specific extension traits (not sealed) (1, 2), we may not consider this is a breaking change that requires a major version bump.)

Related: smol-rs/async-fs#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add windows::CommandExt::raw_arg on Rust 1.62+ smol-rs/async-process
1 participant
@taiki-e