Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was metadata removed from a previous version of async-task? #38

Closed
notgull opened this issue Nov 9, 2022 · 2 comments
Closed

Why was metadata removed from a previous version of async-task? #38

notgull opened this issue Nov 9, 2022 · 2 comments

Comments

@notgull
Copy link
Member

notgull commented Nov 9, 2022

While I was browsing older commits for this crate, I noticed this one, where the original author removed metadata. Recently, we merged #33, which added metadata to tasks. Why was metadata originally removed from tasks? If the reason is still salient for the current version of async-task, we may want to revert #33.

@taiki-e
Copy link
Collaborator

taiki-e commented Nov 23, 2022

I don't know the context of that commit, but if I look at the examples changed in that commit, I see that the type aliases were defined every time. (also, there are a lot of "()" arguments) I guess such a lack of convenience of APIs is the motivation for that commit.

@notgull
Copy link
Member Author

notgull commented Nov 23, 2022

That makes sense. Our new version aliases the metadata to () by default, though, so we should be alright.

@notgull notgull closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants