This repository has been archived by the owner on Aug 24, 2019. It is now read-only.
Fix JSXAttribute generation typo #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 18 18
Lines 203 203
Branches 50 50
=======================================
Hits 178 178
Misses 20 20
Partials 5 5
Continue to review full report at Codecov.
|
gregberge
pushed a commit
to gregberge/svgr
that referenced
this pull request
Sep 16, 2018
In this diff I introduce the new option `svgProps` which is similar to
svgAttributes but applies values in interpolation style `{true}`.
This allows to specify expressions depending on template values for
example default `currentColor` in `fill` prop.
I mentioned in comment about later fixing api to smooth-code/h2x#13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.