fix: toFill doesn't empty contents when given an empty string (#381)

Co-authored-by: Tony Brix <tony@brix.ninja>
argos-ci · Apr 16, 2021 · 964b9a2 · 964b9a2
1 parent a7b5693
commit 964b9a2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/expect-puppeteer/src/matchers/toFill.js b/packages/expect-puppeteer/src/matchers/toFill.js
@@ -8,6 +8,7 @@ async function toFill(instance, selector, value, options) {
     toMatchElementOptions,
   )
   await element.click({ clickCount: 3 })
+  await element.press('Backspace')
   await element.type(value, {
     delay,
   })

diff --git a/packages/expect-puppeteer/src/matchers/toFill.test.js b/packages/expect-puppeteer/src/matchers/toFill.test.js
@@ -18,6 +18,15 @@ describe('toFill', () => {
       expect(value).toBe('James')
     })
 
+    it('should empty the input given an empty string', async () => {
+      await expect(page).toFill('[name="firstName"]', 'James')
+      await expect(page).toFill('[name="firstName"]', '')
+      const value = await page.evaluate(
+        () => document.querySelector('[name="firstName"]').value,
+      )
+      expect(value).toBe('')
+    })
+
     it('should return an error if text is not in the page', async () => {
       expect.assertions(2)