Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tab throttling #137

Closed
gregberge opened this issue Sep 23, 2018 · 0 comments · Fixed by #144
Closed

Disable tab throttling #137

gregberge opened this issue Sep 23, 2018 · 0 comments · Fixed by #144
Labels
enhancement ✨ good first issue 🤙 Good for newcomers

Comments

@gregberge
Copy link
Member

As suggested in #121 and in this article, Chromium throttling behaviour can cause flakiness in tests.

To avoid that, we have to add these flags in default config.

https://github.com/smooth-code/jest-puppeteer/blob/3fcbaf86efb94f764c0b53deb859c746d285732c/packages/jest-environment-puppeteer/src/readConfig.js#L15

'--disable-background-timer-throttling'
'--disable-backgrounding-occluded-windows'
'--disable-renderer-backgrounding'
@gregberge gregberge mentioned this issue Sep 23, 2018
Closed
@brendonbribeiro brendonbribeiro mentioned this issue Sep 28, 2018
Merged
gregberge pushed a commit that referenced this issue Sep 30, 2018
@brendonbribeiro @gregberge
feat: disable tab throttling (#144)
b92e76c 
Closes #137
aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Nov 1, 2018
@aslushnikov
fix(launcher): add flags to improve reliability
63b6847 
- The "IPC flooding protection" was added in https://crrev.com/604305
and should be disabled for our automation usescases.
- The other two flags are coming from argos-ci/jest-puppeteer#137
@aslushnikov aslushnikov mentioned this issue Nov 1, 2018
Merged
aslushnikov added a commit to puppeteer/puppeteer that referenced this issue Nov 1, 2018
@aslushnikov
fix(launcher): add flags to improve reliability (#3474)
2a88690 
- The "IPC flooding protection" was added in https://crrev.com/604305
and should be disabled for our automation usescases.
- The other two flags are coming from argos-ci/jest-puppeteer#137
d-fence added a commit to odoo-dev/odoo that referenced this issue Aug 21, 2019
@d-fence
[IMP] tests: disable a few more chrome things
0641754 
* disable background networking like GoogleUrlTracker ...
  see https://codereview.chromium.org/3312014

* disable backgrounding occluded windows is a CLI swith that was
specifically written for tests to avoid non deterministic behavior.  To
avoid test flakiness, it should come with disable renderer-backgrounding
and disable background-throttling as stated here:
argos-ci/jest-puppeteer#137

* disable breakpad is used to disable crash reporting, the difference
with disable crash-reporter is not clear.
see https://peter.sh/experiments/chromium-command-line-switches/

* disable defaults-apps, prevent installation of default apps on the
first run

* disable dev-shm usage that may cause crashes
robodoo pushed a commit to odoo/odoo that referenced this issue Aug 23, 2019
@d-fence
[IMP] tests: disable a few more chrome things
f5f940a 
* disable background networking like GoogleUrlTracker ...
  see https://codereview.chromium.org/3312014

* disable backgrounding occluded windows is a CLI swith that was
specifically written for tests to avoid non deterministic behavior.  To
avoid test flakiness, it should come with disable renderer-backgrounding
and disable background-throttling as stated here:
argos-ci/jest-puppeteer#137

* disable breakpad is used to disable crash reporting, the difference
with disable crash-reporter is not clear.
see https://peter.sh/experiments/chromium-command-line-switches/

* disable defaults-apps, prevent installation of default apps on the
first run

* disable dev-shm usage that may cause crashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ good first issue 🤙 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable tab throttling brendonbribeiro/jest-puppeteer
1 participant
@gregberge