feat:support multiple servers #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulakowka
approved these changes
Dec 3, 2018
gregberge
requested changes
Dec 3, 2018
There was a problem hiding this comment.
Hello @xiaoyuhen, thanks for your work! Just some changes:
portis not mandatory, you can't rely on it for mapping. Please use array index instead.- You don't have to modify
jest-puppeteer.config.jsandreadmeexample. Passing an object instead of array will be supported, it is the first class usage. We should just mention that it is possible to specify several servers.
|
hi, @neoziro |
|
No it’s OK for me, I will merge it as soon as I have a moment! Thanks for your work! |
gregberge
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
support multiple servers and compatible with older versions
see #134