Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Firefox thx to puppeteer-firefox #171

Closed
tkrotoff opened this issue Dec 13, 2018 · 4 comments · Fixed by #220
Closed

Add support for Firefox thx to puppeteer-firefox #171

tkrotoff opened this issue Dec 13, 2018 · 4 comments · Fixed by #220
Labels
feature request 🙏

Comments

@tkrotoff
Copy link
Contributor

Add support for Firefox thanks to puppeteer-firefox 😻
@xiaoyuhen
Copy link
Contributor

This project is experimental. 🐊 live here.

@philipp-spiess
Copy link

philipp-spiess commented Mar 28, 2019 •
edited
Loading

I quickly tried to use jest-puppeteer with puppeteer-firefox by renaming node_modules/puppeteer-firefox to node_modules/puppeteer and I could run my (well, currently very limited set of) tests just fine!

Grepping for the puppeteer imports in this project it seems like this is limited to only these two lines:

https://github.com/smooth-code/jest-puppeteer/blob/f3bb9415e52207f5f4d293aee3bf7783e1bccce9/packages/jest-environment-puppeteer/src/global.js#L8

https://github.com/smooth-code/jest-puppeteer/blob/f3bb9415e52207f5f4d293aee3bf7783e1bccce9/packages/jest-environment-puppeteer/src/PuppeteerEnvironment.js#L3

Would you take a PR that links those to a seperate file which can be configured to either load puppeteer (default) or puppeteer-firefox (opt in)? Do you have any better ideas to do that? 🙂

@gregberge
Copy link
Member

Hello @philipp-spiess, it's a very good news! I think we could provide support for it in future!

aslushnikov added a commit to aslushnikov/jest-puppeteer that referenced this issue Apr 4, 2019
@aslushnikov
feat: support "browser" config option
1cb9911 
Fixes argos-ci#171
aslushnikov added a commit to aslushnikov/jest-puppeteer that referenced this issue Apr 4, 2019
@aslushnikov
feat: support "browser" config option
b938bb1 
Fixes argos-ci#171
@aslushnikov aslushnikov mentioned this issue Apr 4, 2019
Merged
@gregberge gregberge mentioned this issue Apr 15, 2019
Closed
aslushnikov added a commit to aslushnikov/jest-puppeteer that referenced this issue Apr 19, 2019
@aslushnikov
feat: support "browser" config option
c5ea20b 
Fixes argos-ci#171
xiaoyuhen pushed a commit that referenced this issue May 6, 2019
@aslushnikov @xiaoyuhen
feat: support "browser" config option (#220)
85a1122 
* feat: support "browser" config option

Fixes #171

* add note

* fix error message
@yairEO
Copy link

yairEO commented Jun 1, 2020 •
edited
Loading

Related to #312 (Puppeteer v2.1.0 supports Firefox out-of-the-box)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support "browser" config option aslushnikov/jest-puppeteer
5 participants
@gregberge @philipp-spiess @tkrotoff @yairEO @xiaoyuhen