Accept a promise as config #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregberge
requested changes
Dec 29, 2018
| @@ -113,19 +113,22 @@ This example uses an already running instance of Chrome by passing the active we | |||
|
|
|||
| ```js | |||
| // jest-puppeteer.config.js | |||
| const wsEndpoint = fs.readFileSync(endpointPath, 'utf8') | |||
| const PromiseForConfig = PromiseForWsEndpoint | |||
There was a problem hiding this comment.
Your example is not enought explicit. Can you please make it more explicit? I mean PromiseForWsEndpoint should be defined. Also no first uppercase for promises please, they are not classes.
There was a problem hiding this comment.
I replaced the example with a new one based on the actual code I use in my project
gregberge
approved these changes
Jan 1, 2019
|
Thanks again for your work, it will be released soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves #176
Test plan
The change was implemented in TDD.