Increase peerDependencies to allow Puppeteer v2 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added Node.js 12 to the Travis config too 😊 |
|
@gregberge any progress on this? |
|
@gregberge can you merge this pr? |
|
Thanks! Sorry for delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
peerDependenciesonly allows"puppeteer": "^1.5.0".Puppeteer v2 was released yesterday:
https://github.com/GoogleChrome/puppeteer/releases/tag/v2.0.0
It drops support for Node.js 6, and since jest-puppeteer only supports Node.js 8+ anyway we can make this a non-breaking change.
Test plan
Currently, jest-puppeteer runs its tests using
puppeteer@1.18.1, so a puppeteer upgrade actually causes a breakage inpage.waitForSelector('html')wherepageis a frame.It seems to be hitting this bug: puppeteer/puppeteer#2602
But the following quick fix resolves the issues:
Before
Which causes a protocol error:
After
This works instead:
Otherwise the upgrade to Puppeteer v2 was fairly seamless.