Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require to puppeteer-core as fallback #315

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Conversation

rwu823
Copy link
Contributor

@rwu823 rwu823 commented Feb 7, 2020

Summary

This is because sometimes we prefer puppeteer-core as a dependency instead of puppeteer.

@gregberge gregberge merged commit 49d313c into argos-ci:master Feb 16, 2020
@gregberge
Copy link
Member

Thanks!

@gziolo
Copy link

gziolo commented Apr 17, 2020

Awesome, I was about to propose something similar to avoid aliasing puppeteer as follows:

"puppeteer": "npm:puppeteer-core@3.0.0",

When do you plan to publish a new version of the package that includes this PR?

@murraymichal
Copy link

The 4.4.0 is without this change. When it will be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants