fix: Leverage Puppeteer's native support for Firefox #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this will work out of the box unless you also increase the puppeteer version in |
UziTech
suggested changes
Apr 8, 2021
Comment on lines
-56
to
-60
| try { | ||
| return require('puppeteer') | ||
| } catch (e) { | ||
| return require('puppeteer-core') | ||
| } |
There was a problem hiding this comment.
I think we need to keep the getPuppeteer function to allow using puppeteer or puppeteer-core
BREAKING CHANGE: browser config is deprecated use launch.product instead.
UziTech
approved these changes
Apr 16, 2021
UziTech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to address #312. Puppeteer now supports firefox natively. As such, support for puppeteer-firefox is no longer required. This PR replaces the
browserproperty injest-puppeteer.config.jsin favor of the nativelaunch.productkey.Test plan
All existing tests pass and a new test was added to ensure that the
launch.productvalue matches eitherfirefoxorchrome.