Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option runBeforeUnloadOnClose #504

Merged
merged 4 commits into from
Nov 26, 2022
Merged

Add option runBeforeUnloadOnClose #504

merged 4 commits into from
Nov 26, 2022

Conversation

Ayc0
Copy link
Contributor

@Ayc0 Ayc0 commented Nov 25, 2022

Summary

Closes #362

Introduce a new option runBeforeUnloadOnClose that controls whether or not page.close should be called with runBeforeUnload: true

Test plan

Tests were added:

image

@Ayc0 Ayc0 changed the title Ayc0/runbeforeunload Add option runBeforeUnloadOnClose Nov 25, 2022
@Ayc0 Ayc0 mentioned this pull request Nov 25, 2022
Closed
@UziTech UziTech merged commit 317ed12 into argos-ci:master Nov 26, 2022
@Ayc0 Ayc0 deleted the Ayc0/runbeforeunload branch November 26, 2022 17:04
@Ayc0
Copy link
Contributor Author

Ayc0 commented Nov 26, 2022

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beforeunload dialog is not triggered
2 participants
@Ayc0 @UziTech