Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backoff/retry/log when rate-limited #10

Open
alexbowe opened this issue Feb 24, 2023 · 2 comments
Open

Backoff/retry/log when rate-limited #10

alexbowe opened this issue Feb 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@alexbowe
Copy link
Collaborator

alexbowe commented Feb 24, 2023 •
edited
Loading

Readwise's API rate-limits, which could make responses not have a "results" section as seen in #1.

We should backoff and try again (probably using Python's backoff lib)
@alexbowe alexbowe added the enhancement New feature or request label Feb 24, 2023
@alexbowe
Copy link
Collaborator Author

I attempted to overload the rate limiter and could not reproduce the bug, so this may not be a high priority right now. Removing from epic. Will prioritize it if people start to report problems around it.

@alexbowe alexbowe changed the title Backoff/retry when rate-limited Backoff/retry/log when rate-limited Mar 13, 2023
@alexbowe
Copy link
Collaborator Author

from https://readwise.io/api_deets:

Rate Limiting
The default base rate is 240 requests per minute but the Highlight LIST and Book LIST endpoints are restricted to 20 per minute. You can check Retry-After header in the 429 response to get the amount of seconds to wait for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexbowe