Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use derived input for star_index #81

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

bilalshaikh42
Copy link
Contributor

the file path for the -sjdbGTFfile parameter was hardcoded to 'resources/genome.gtf' which causes execution to fail due to missing files on remote execution environments without a shared filesystem (such as kubernetes)

This derives the filepath correctly from the input property to fix this issue

the file path for the -sjdbGTFfile parameter was hardcoded to 'resources/genome.gtf' which causes execution to fail due to missing files on remote execution environments without a shared filesystem (such as kubernetes)

This derives the filepath correctly from the input property to fix this issue
Copy link
Contributor

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. But good catch, thanks for the clear fix, and thanks for the explanation!

@dlaehnemann dlaehnemann merged commit 87fffe6 into snakemake-workflows:master Jun 5, 2024
4 checks passed
@dlaehnemann
Copy link
Contributor

Thanks again, @bilalshaikh42. I just fixed the formatting and merged this, it is now released with the version tag v2.1.2, so you can point your module import statement to that to get the fix into your deployment of the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants