Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts Refactoring + Utilities #367

Open
cycomachead opened this issue Aug 16, 2024 · 0 comments
Open

Layouts Refactoring + Utilities #367

cycomachead opened this issue Aug 16, 2024 · 0 comments

Comments

@cycomachead
Copy link
Member

We have a lot of layouts which are:

  • heading + grid of items
  • a collection of carousels

We need a page type which has:

  • title / locale string
  • items to display
  • grid parameters

All 3 could easily be defined in the controller. We could keep one lua template per route and make this a large partial, which might be little cleaner

A second page/large partial for a collection of collections.

Common Helpers

  • font awesome function
  • we should have a set title yield in the main layout
  • probably a helper to translate "items per page" to col-X classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant