Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning when compiling with dart-sass (slash-div) #2749

Open
salami-art opened this issue May 30, 2022 · 3 comments
Open

Deprecation warning when compiling with dart-sass (slash-div) #2749

salami-art opened this issue May 30, 2022 · 3 comments

Comments

@salami-art
Copy link

salami-art commented May 30, 2022

I had issues with node-sass, so I decided to updata to dart-sass, bootstrap-select works fine, however, i'm getting a deprecation warning for a line in the component's styles:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($amnt, 100) or calc($amnt / 100)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
26 │     $amnt: $amnt / 100; // convert to percentage if int
   │            ^^^^^^^^^^^
   ╵
    node_modules/bootstrap-select/sass/bootstrap-select.scss 26:12   fade()
    node_modules/bootstrap-select/sass/bootstrap-select.scss 352:43  @import
    [...]

It would be nice if someone updated the source code to use the newer recommended syntax. I am available for submitting a PR.

@caseyjhol
Copy link
Member

Thanks for reporting this. Please submit a PR if you have the bandwidth and we'll get this merged - thanks!

@salami-art
Copy link
Author

salami-art commented Jun 6, 2022

I don't know how to edit on the 1.13.X though, I'm still using that ( that piece of code was even changed on 1.14.X #2669 )

@guustnieuwenhuis
Copy link

Hi all,
I've created a PR to resolve this issue. I've branched of v1.13.18 for this. Could this be released in a v1.13.19?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants