many: add default-configure hook #12701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
ernestl
force-pushed
the
EL_SNAPDENG-6486_Default_Configure_Hook
branch
2 times, most recently
from
1b5ee05 to
5e99685
Compare
ernestl
commented
Apr 7, 2023
ernestl
force-pushed
the
EL_SNAPDENG-6486_Default_Configure_Hook
branch
from
5e99685 to
0480d37
Compare
mvo5
reviewed
Apr 17, 2023
ernestl
force-pushed
the
EL_SNAPDENG-6486_Default_Configure_Hook
branch
from
2b7e641 to
3b2cace
Compare
ernestl
added
Needs Samuele review
pedronis
reviewed
Apr 19, 2023
ernestl
commented
Apr 20, 2023
pedronis
approved these changes
Apr 20, 2023
miguelpires
approved these changes
Apr 20, 2023
ernestl
force-pushed
the
EL_SNAPDENG-6486_Default_Configure_Hook
branch
from
e13319a to
f53ef01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://docs.google.com/document/d/1QDlVmTCtRAe0SxyvMZ97NlcosEtf1-MCmGcsRixDbek
Two parts:
(1) Implementation and unit tests: #12701 <- this is part 1
(2) Spread test: #12747
snap/hooktypes.go:
overlord/configstate/configmgr.go:
overlord/configstate/configstate.go:
DefaultConfigurethat provides the task set for the default configure hook. It is significantly simplified compared to the configure hook due to simpler mandate to configure snap with gadget defaults on first install for non-core snaps.overlord/configstate/hooks.go:
defaultConfigureHandlerwith functions that satisfy the same interface asConfigureHandlerwith Before, Error and Done.Beforeto only apply defaults if default-configure is not available, otherwise "configuration empty change" as per specification.
Beforereturns with error if there is not a configure hook so that "default-configure will be taken into account only if there is also a configure hook" as per specification.overlord/snapstate/check_snap.go:
overlord/snapstate/snapstate.go:
DefaultConfigureafter installation and right before service starting task.