Snap is outdated

[Kedstar99]

It's been a while since vscode 1.29.1 has been launched. The snap is still stuck with 1.29.

Is there currently a CI pipeline that triggers when vscode is updated?

[meddario]

As a notice, I think that it would be better to completely disable the in-app notification for the snap build (if possible). It's a bit confusing because the user can't really do anything to update the app.

[popey]

@Kedstar99 Thanks for the ping! A build has been triggered. The easiest way for anyone to trigger a build is actually to just change a file in the repo via a PR. If you (for example) make a change to the .build-trigger.txt file in the root of the project (cunning name, huh? :) ) it will trigger a build via travis that we can check & merge. That'll trigger a build which will hit the store.

@meddario You're right, if someone could figure out if there's an option we can set somewhere in the build process to do that, it would be awesome.

[popey]

Unfortunately a technical issue in launchpad meant I had to build multiple times to get it uploaded. This is now done. Apologies for the delay.

[meddario]

@popey i was checking if there is a way to disable the notification, i noticed this: https://github.com/Microsoft/vscode/blob/8f688a4ccf7bb996475b71e13693bd5c7b1af0ee/src/vs/platform/update/electron-main/updateService.linux.ts#L81, apparently there's already a snap update check, maybe it's not working correctly.
Tomorrow i'll clone the source code to do a better check, if there is a vscode bug i'll open an issue.

[Kedstar99]

Looking at the code and the resource, it appears to be looking for
/snap/code/current
rather than
/snap/vscode/current

As such I would be curious to see if this is being logged.
'update#checkForSnapUpdate(): Could not get realpath of application.'

I have proposed a fix that checks via environment variable the correct directory.

Would it be ok if I file a bug? I will credit and add you to the list too?

[meddario]

@Kedstar99 sorry for the delay! Yes, it's ok, glad i could help!