NoSQL: realm-management minor fixes (#69)

* always set the `updated` `Instant` of a realm (do not rely on the caller doing this)
* fix issue that transition from `INACTIVE` to `ACTIVE` _is_ intended and definitely allowed
* let `PersistenceMetaStoreManagerFactory#bootstrapRealm` handle the `CREATED` state as well for bootstrapping a realm

Author: snazy

extension/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/PersistenceMetaStoreManagerFactory.java

@@ -290,6 +290,16 @@ private PrincipalSecretsResult bootstrapRealm(
               return desc;
             });
 
+    if (realmDesc.status() == RealmDefinition.RealmStatus.CREATED) {
+      realmDesc =
+          realmManagement.update(
+              realmDesc,
+              RealmDefinition.builder()
+                  .from(realmDesc)
+                  .status(RealmDefinition.RealmStatus.INITIALIZING)
+                  .build());
+    }
+
     checkState(
         realmDesc.status() == RealmDefinition.RealmStatus.INITIALIZING,
         "Unexpected status '%s' for realm '%s'",

extension/persistence/nosql/realms/impl/src/main/java/org/apache/polaris/realms/impl/RealmManagementImpl.java

@@ -46,6 +46,7 @@ class RealmManagementImpl implements RealmManagement {
   private final RealmStore store;
   private final Supplier<Instant> clock;
 
+  @SuppressWarnings("CdiInjectionPointsInspection")
   @Inject
   RealmManagementImpl(RealmStore store, MonotonicClock clock) {
     this(store, clock::currentInstant);
@@ -122,7 +123,9 @@ private void verifyStateTransition(RealmDefinition expected, RealmDefinition upd
               update.status());
       case INACTIVE ->
           checkArgument(
-              update.status() == INACTIVE || update.status() == PURGING,
+              update.status() == ACTIVE
+                  || update.status() == INACTIVE
+                  || update.status() == PURGING,
               "Invalid realm state transition from %s to %s",
               expected.status(),
               update.status());
@@ -160,7 +163,8 @@ public RealmDefinition update(
             throw new RealmExpectedStateMismatchException(
                 "Realm does not match the expected state");
           }
-          return update;
+          var now = clock.get();
+          return ImmutableRealmDefinition.builder().from(update).updated(now).build();
         });
   }