Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the cut-limit for a command #266

Merged
merged 1 commit into from
May 14, 2016
Merged

Increase the cut-limit for a command #266

merged 1 commit into from
May 14, 2016

Conversation

goetas
Copy link
Contributor

@goetas goetas commented May 5, 2016

This will make logs more readable

@snc snc merged commit 366c045 into snc:master May 14, 2016
@snc
Copy link
Owner

snc commented May 14, 2016

Thanks, merged.

@Seldaek
Copy link
Collaborator

Seldaek commented Jun 15, 2016

Why not remove this substr()/toStringArgumentReducer entirely? It's the job of the profiler UI to restrict the data shown if needed IMO, but the logs shouldn't be truncated :/ I didn't find any reason why this was added in #172 (cc @theUniC).

@theUniC
Copy link
Contributor

theUniC commented Jun 15, 2016

In #172 I only continued with a previous work to make this bundle work with PRedis 1.0 in #150.

@Seldaek
Copy link
Collaborator

Seldaek commented Jun 15, 2016

OK so it was @mattmontgomery who did it, I missed that. Any clue about the issue here @mattmontgomery? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goetas @snc @Seldaek @theUniC