-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snitch missing from meson WrapDB #156
Comments
@willwray contributed the meson build scripts and the WrapDB integration. Perhaps he knows why snitch isn't listed there anymore? |
Yes, I wrote that doc... It surely should be possible now. I'll aim to have another go today and report back. I'd intended to get the submission working and accepted quickly and imagined that wouldn't be too hard. IIRC the way WrapDB worked made things harder than expected. There was an irritating chicken-and-egg situation involving a temporary patch file, waiting for a next release and then file conflicts. Things may have changed. WrapDB was (is?) mostly used for libraries that need 'wrapping', i.e. libraries with foreign builds that then include a patch file to add meson build. The meson build setup added to snitch eliminates the need for a 'wrap' patch file; here WrapDB is simply for distribution of a library with native meson build. WrapDB had a policy of only working from file-archive releases, despite that meson wrap itself is happy to work from github. The reason given was security, in case users lazily pulled from random github project HEADs. IIRC the patch file I added collided with the file archive unpack so couldn't pass WrapDB CI. Lesson; don't write wishful docs. Write what is, fix it, then write was is new. |
Ahah, there was much more story there than I expected! What should we do, then? Is inclusion in WrapDB not needed anymore because we have native Meson support, hence the docs should be updated to not mention it? Or do we still want to be listed there and make the current docs true? |
The wrapDB is also useful as a packaging system for people building with meson, not just for packages that require patch. See: https://mesonbuild.com/Adding-new-projects-to-wrapdb.html
In my opinion, having snitch available in this way would make it better accessible and easier to set up for meson users (as described in the wishful docs). But of course, it depends first on whether someone is willing to create (and maintain?) the wrap file. |
That sounds sensible, yes. Not using Meson myself, I have little motivation to maintain this, but our door is wide open for contributions ;) |
According to the docs, snitch should be available in Meson WrapDB, but that doesn't seem to be the case.
The 'meson wrap install snitch' command says 'ERROR: Wrap snitch not found in wrapdb'.
Also I don't see 'snitch' in the list of packages: https://mesonbuild.com/Wrapdb-projects.html
The text was updated successfully, but these errors were encountered: