Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capture/section state after unhandled exception(s) #178

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Fix capture/section state after unhandled exception(s) #178

merged 7 commits into from
Aug 29, 2024

Conversation

cschreib
Copy link
Member

@cschreib cschreib commented Aug 22, 2024 •
edited
Loading

This PR does the following:

  • Fix CAPTURE not displayed when exception is caught #177 by checking for unhandled exception before popping capture data that goes out of scope. This also affected SECTION.
  • Add explicit casts in internal code to avoid potential ambiguous calls to append() when user defines their own overloads.
  • Fix the codecov configuration.

@cschreib cschreib mentioned this pull request Aug 22, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (d663212) to head (7994241).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   94.00%   94.03%   +0.03%     
==========================================
  Files          29       29              
  Lines        1700     1709       +9     
==========================================
+ Hits         1598     1607       +9     
  Misses        102      102
Files with missing lines Coverage Δ
include/snitch/snitch_capture.hpp 100.00% <100.00%> (ø)
include/snitch/snitch_string_utility.hpp 100.00% <ø> (ø)
src/snitch_capture.cpp 92.00% <100.00%> (+0.69%) ⬆️
src/snitch_registry.cpp 95.18% <100.00%> (+0.05%) ⬆️
src/snitch_section.cpp 85.71% <100.00%> (+0.71%) ⬆️
src/snitch_test_data.cpp 95.65% <100.00%> (+0.19%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d663212...7994241. Read the comment docs.

tocic
tocic previously approved these changes Aug 28, 2024
View reviewed changes
@cschreib cschreib mentioned this pull request Aug 28, 2024
Closed
@cschreib
Copy link
Member Author

Thanks for the review @tocic, sorry I had unpushed changes. The issue reported in #177 also affected SECTION(...), the last commit addresses this. This PR should be complete now ;)

@cschreib cschreib changed the title Fix #177 Fix capture/section state after unhandled exception(s) Aug 28, 2024
@cschreib cschreib merged commit fab51bf into main Aug 29, 2024
43 checks passed
@cschreib cschreib mentioned this pull request Sep 27, 2024
Merged
@cschreib cschreib deleted the capture branch September 29, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tocic tocic tocic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CAPTURE not displayed when exception is caught
2 participants
@cschreib @tocic