-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac M1 stopped working #393
Comments
Plugging in Brave should work, make sure executablePath is exactly what navigating to |
Also, i think you also need to replace You may or may not have to do that, so try the simple solution first, getting the right executable path from |
Ok so I followed the post solution...
npm uninstall puppeteer; npm i puppeteer-core
npm i; npm run build
Then on these files src/destreamer.ts, src/PuppeteerHelper.ts, and src/TokenCache.ts, I changed
import puppeteer from 'puppeteer-core'
Then I build again using
npm i; npm run build
But now I have these errors:
up to date, audited 435 packages in 513ms
46 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
***@***.*** build
echo Transpiling TypeScript to JavaScript... && node node_modules/typescript/bin/tsc && echo Destreamer was built successfully.
Transpiling TypeScript to JavaScript...
src/PuppeteerHelper.ts:14:26 - error TS2339: Property 'executablePath' does not exist on type 'typeof import("/Users/Steve/destreamer/node_modules/puppeteer-core/lib/types")'.
14 return puppeteer.executablePath();
~~~~~~~~~~~~~~
src/PuppeteerHelper.ts:17:43 - error TS2339: Property 'executablePath' does not exist on type 'typeof import("/Users/Steve/destreamer/node_modules/puppeteer-core/lib/types")'.
17 const browserPath: string = puppeteer.executablePath()
~~~~~~~~~~~~~~
Found 2 errors.
Any clue how to fix this?
…On 28 Jun 2021, 4:20 AM -0700, Adrian Calinescu ***@***.***>, wrote:
My bad, i think you also need to replace puppeteer with puppeteer for M1 Macs. See this other issue which has the solution -
#355
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
It works perfectly on Mac M1. My steps are below.
|
I'm sorry for the late reply but life got in the way. Do you still need help? |
It would be nice with a pre fixed M1 version 🤷🏼♂️ |
Happy to be gifted an M1 to build and test on. Let it be an Ultra just to make sure we cover that as well :) But seriously though, if someone with an M1 sends a pull request with a fix, I'll merge it in. |
I’m just gonna win the lottery and it will be on it’s way 😉 @hidehiro98 seems to know what he’s doing. Any chances for a pull request? |
if ppl come looking for a fix on M1 macs and/or latest macOS see this #487 (comment) |
I recently got an M1 Mac, it stopped recognising the chromium even tho i have chronium installed.
the error:
Launching headless Chrome to perform the OpenID Connect dance...
[ERROR] Error: Failed to launch the browser process! spawn /usr/bin/chromium-browser ENOENT
TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md
i have tried changing the path into chrome with following code and rebuild but still no luck
executablePath: '/Applications/Brave Browser.app/Contents/MacOS/Brave Browser',
The text was updated successfully, but these errors were encountered: