Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up devfile exec package functions #5

Closed
snowdrop-bot opened this issue Jul 17, 2020 · 0 comments
Closed

Clean up devfile exec package functions #5

snowdrop-bot opened this issue Jul 17, 2020 · 0 comments

Comments

@snowdrop-bot
Copy link

pkg/exec/devfile.go's ExecuteDevfileRunActionWithoutRestart(), ExecuteDevfileDebugActionWithoutRestart is ~95% similar to their non restart counterparts ExecuteDevfileRunAction, ExecuteDevfileDebugAction

To me it looks like a lot of redundant code and can be massively cleaned up by modifying the prev existing functions to handle non restarts.

Came across this when looking at ways to refactor kube/docker adapter's execDevfile() func in redhat-developer#3015

/area devfile
/kind cleanup


redhat-developer#3518


$upstream:3518$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants