You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pkg/exec/devfile.go's ExecuteDevfileRunActionWithoutRestart(), ExecuteDevfileDebugActionWithoutRestart is ~95% similar to their non restart counterparts ExecuteDevfileRunAction, ExecuteDevfileDebugAction
To me it looks like a lot of redundant code and can be massively cleaned up by modifying the prev existing functions to handle non restarts.
Came across this when looking at ways to refactor kube/docker adapter's execDevfile() func in redhat-developer#3015
pkg/exec/devfile.go's
ExecuteDevfileRunActionWithoutRestart()
,ExecuteDevfileDebugActionWithoutRestart
is ~95% similar to their non restart counterpartsExecuteDevfileRunAction
,ExecuteDevfileDebugAction
To me it looks like a lot of redundant code and can be massively cleaned up by modifying the prev existing functions to handle non restarts.
Came across this when looking at ways to refactor kube/docker adapter's execDevfile() func in redhat-developer#3015
/area devfile
/kind cleanup
redhat-developer#3518
The text was updated successfully, but these errors were encountered: