Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testsuite into the BOM repository #87

Open
gytis opened this issue Mar 19, 2020 · 8 comments
Open

Move testsuite into the BOM repository #87

gytis opened this issue Mar 19, 2020 · 8 comments

Comments

@gytis
Copy link
Collaborator

gytis commented Mar 19, 2020

Correct me if I'm wrong, but the testsuite is only used to test the BOM, right? So maybe it would be more logical to move it under the same repository as the BOM? What do you think?
@cmoulliard @metacosm @geoand @iocanel @aureamunoz @jacobdotcosta

@geoand
Copy link
Member

geoand commented Mar 19, 2020

That is correct.

I am not convinced however that moving the testsuite is the best idea

@gytis
Copy link
Collaborator Author

gytis commented Mar 19, 2020

Why not?

@geoand
Copy link
Member

geoand commented Mar 19, 2020

I just think the repository should be BOM only.
But then again I'm definitely not going to loose any sleep if we do move it in 😂

@gytis
Copy link
Collaborator Author

gytis commented Mar 20, 2020

I think it would be nice to get rid of all the bash magic in the CI configuration. Now we needs to clone, modify the pom.xml in different ways to align the version, build it etc. It might make runs faster too.

We could move all of it to the integration-tests directory. So it shouldn't pollute the repo too much either.

@geoand
Copy link
Member

geoand commented Mar 20, 2020

I personally wouldn't do it, but I do see some merit no doubt :). Whatever you prefer.

@gytis
Copy link
Collaborator Author

gytis commented Mar 20, 2020

I'm not married to the idea, just thought of it yesterday while trying to make CI work with 2.2.5. Just wanted to get others input on this.

@metacosm
Copy link
Member

I see merits in both points of view. Let's decide on this at the next weekly.

@aureamunoz
Copy link
Contributor

I think I prefer Gytis' proposition but I've not played enought with this to have a strong advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants