Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW Fix tests which were lacking order by clause #1290

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jan 14, 2025

Description

NO-SNOW some tests started failing because select didn't have order by clause.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (dda273b) to head (8f0bdc6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
- Coverage   82.26%   82.25%   -0.02%     
==========================================
  Files          55       55              
  Lines       13569    13569              
==========================================
- Hits        11163    11161       -2     
- Misses       2406     2408       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review January 15, 2025 06:50
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner January 15, 2025 06:50
@sfc-gh-pfus sfc-gh-pfus enabled auto-merge (squash) January 15, 2025 09:24
@sfc-gh-pfus sfc-gh-pfus merged commit 220e36e into master Jan 15, 2025
38 of 39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the test.order.by branch January 15, 2025 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants