SNOW-1313648 GO - Verify value bindings for all field types while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD #1297
+226
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1297 +/- ##
==========================================
- Coverage 82.16% 82.03% -0.14%
==========================================
Files 55 55
Lines 13634 13670 +36
==========================================
+ Hits 11203 11214 +11
- Misses 2431 2456 +25 ☔ View full report in Codecov by Sentry. |
sfc-gh-ext-simba-jy
changed the title
sfc-gh-ext-simba-jy
requested review from
sfc-gh-pfus,
sfc-gh-pmotacki and
sfc-gh-pbulawa
sfc-gh-pfus
reviewed
Feb 6, 2025
sfc-gh-pfus
reviewed
Feb 10, 2025
sfc-gh-pfus
approved these changes
Feb 12, 2025
bindings_test.go
Outdated
| @@ -1423,3 +1547,11 @@ func testInsertLOBData(t *testing.T, useArrowFormat bool, isLiteral bool) { | |||
| dbt.mustExec(unsetFeatureMaxLOBSize) | |||
| }) | |||
| } | |||
|
|
|||
| func getRandomDate() time.Time { | |||
| return time.Date(rand.Intn(1700)+1, time.January, rand.Intn(40), rand.Intn(40), rand.Intn(40), rand.Intn(40), rand.Intn(40), time.UTC) | |||
There was a problem hiding this comment.
why date is > 1700? we should test also values below 1582 (julian to gregorian calendar switch)
There was a problem hiding this comment.
When I reproduced the error, the time shift occurred in the year before 1700/1/1 as far as I remember. However, we can use 1582 in this case. I replaced the value. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-313648 Please explain the changes you made here.
Checklist