Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose should rollback transaction if not committed #20

Closed
howryu opened this issue Mar 5, 2018 · 1 comment · Fixed by #121
Closed

Dispose should rollback transaction if not committed #20

howryu opened this issue Mar 5, 2018 · 1 comment · Fixed by #121
Assignees

Comments

@howryu
Copy link
Contributor

howryu commented Mar 5, 2018

The SnowflakeDbTransaction does not properly Rollback a transaction upon dispose, I'm not sure where the official guidelines for extending DbTransaction are but the expected behavior is that the protected virtual Dispose method is overridden to Rollback the transaction upon Dispose if the transaction was not committed.

@ikudjoi
Copy link
Contributor

ikudjoi commented Mar 18, 2019

Have you any plans on this and #64? I think that calling dispose should roll back open transactions and at least close connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants