Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1814745: Fix aborting requests in HTTP client. Normalization of responses unified. #967

Merged
merged 23 commits into from
Dec 20, 2024
Merged

SNOW-1814745: Fix aborting requests in HTTP client. Normalization of responses unified. #967

merged 23 commits into from
Dec 20, 2024
+177 −26

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-fpawlowski sfc-gh-fpawlowski changed the base branch from master to SNOW-1631790-Transport-Layer November 19, 2024 14:17
@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Nov 20, 2024
sfc-gh-fpawlowski
sfc-gh-fpawlowski commented Nov 20, 2024
View reviewed changes
lib/http/base.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1631790-Transport-Layer branch from adb13c4 to 6c27246 Compare December 5, 2024 10:20
Base automatically changed from SNOW-1631790-Transport-Layer to master December 5, 2024 11:45
@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review December 16, 2024 23:37
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner December 16, 2024 23:37
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (0aaa740) to head (dbe5de6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/services/sf.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   88.92%   88.95%   +0.03%     
==========================================
  Files          72       72              
  Lines        6950     6955       +5     
==========================================
+ Hits         6180     6187       +7     
+ Misses        770      768       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-fpawlowski sfc-gh-fpawlowski changed the title Snow 1814745 fix aborting requests in http client Snow 1814745: Aborting requests in HTTP client fixed. Normalization of responses unified. Dec 17, 2024
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title Snow 1814745: Aborting requests in HTTP client fixed. Normalization of responses unified. SNOW-1814745: Fix aborting requests in HTTP client. Normalization of responses unified. Dec 17, 2024
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Dec 17, 2024
View reviewed changes
test/integration/testHttpClient.js Outdated Show resolved Hide resolved
ci/container/hang_webserver.py Show resolved Hide resolved
test/integration/testHttpClient.js Outdated Show resolved Hide resolved
test/integration/testHttpClient.js Outdated Show resolved Hide resolved
test/integration/testHttpClient.js Outdated Show resolved Hide resolved
test/integration/testHttpClient.js Outdated Show resolved Hide resolved
test/integration/test_utils/httpInterceptorUtils.js Show resolved Hide resolved
@sfc-gh-fpawlowski
SNOW-1814745-Fix-aborting-requests-in-HttpClient: Made tests function…
dbe5de6 
…alities more reusable. Fixed raising error in tests in callbacks.
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-fpawlowski sfc-gh-fpawlowski merged commit 08d802e into master Dec 20, 2024
47 checks passed
@sfc-gh-fpawlowski sfc-gh-fpawlowski deleted the SNOW-1814745-Fix-aborting-requests-in-HttpClient branch December 20, 2024 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-fpawlowski @sfc-gh-dprzybysz @sfc-gh-pmotacki