Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cabal-doctest library is deprecated #170

Closed
danwdart opened this issue Nov 2, 2021 · 2 comments
Closed

The cabal-doctest library is deprecated #170

danwdart opened this issue Nov 2, 2021 · 2 comments

Comments

@danwdart
Copy link

danwdart commented Nov 2, 2021

See: https://hackage.haskell.org/package/cabal-doctest
which references: haskell/cabal#2327

Does this library still need it specifically? cabal-doctest blocks things from building on ghc 9.2.

@k0ral
Copy link
Collaborator

k0ral commented Nov 2, 2021

This library doesn't need it to work, it's just useful to guarantee that documentation examples are correct.
After reading the links you mentioned, and browsing the topic a little, it's not clear to me how we should achieve the same feature without cabal-doctest library.

Do you happen to know a working alternative ? If there aren't any, I guess we have 2 options:

  1. wait for Support GHC 9.2; CI on GitHub Actions ulidtko/cabal-doctest#72 to get merged/released, then pull that release in xml-conduit
  2. drop cabal-doctest dependency altogether

I'm opening #171 right now, waiting for the outcome of 1/ to either close or merge it.

@k0ral
Copy link
Collaborator

k0ral commented Dec 2, 2021

I've upgraded calab-doctest dependency through #174, which should be compatible with GHC 9.2 .
Don't hesitate to re-open this issue if you still observe an issue.

@k0ral k0ral closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants