Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new AWS resources aws_vpc_security_group_ingress_rule and aws_vpc_security_group_egress_rule #1636

Open
rirze opened this issue Mar 1, 2023 · 0 comments
Labels
kind/enhancement New feature or improvement

Comments

@rirze
Copy link

rirze commented Mar 1, 2023

Description

Hi,

The AWS provider has released newer, consistent resources for managing security group rules:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc_security_group_ingress_rule
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc_security_group_egress_rule

These objects are better at being 1:1 to how AWS manages security group rules, with some benefits being:

  • rules being able to hold tags
  • each rule object only associates one source, unlike the old objects that could reference multiple cidr blocks for example
  • imports are now by security group rule ID, unlike the concatenated property string before

I would assume these new objects would simplify the drift detection code for security group rules in driftctl since they are more straightforward to associate with the corresponding AWS resources. It would be greatly helpful if support could be added in driftctl!

@rirze rirze added the kind/enhancement New feature or improvement label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant