Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/middlewares/aws_route_table_expander.go - NewAwsRouteTableExpander - why does this exist ? #1642

Open
n2N8Z opened this issue Mar 16, 2023 · 0 comments
Labels
kind/bug Something isn't working

Comments

@n2N8Z
Copy link
Contributor

n2N8Z commented Mar 16, 2023

Description

The route table expander middleware (pkg/middlewares/aws_route_table_expander_test.goNewAwsRouteTableExpander) clearly states that it:
"Explodes routes found in aws_default_route_table.route and aws_route_table.route to dedicated resources"
which runs contrary to the purpose of driftctl which is to find "resources not covered by IaC".

Every route that is expanded by this middleware is a route that is not covered bi IaC, and is hidden from the user.
Why does this middleware exist ?

How to reproduce

Run driftctl against any AWS environment with manually added routes, and driftctl will not report those routes.

Possible Solution

Remove aws_route_table_expander_test.goNewAwsRouteTableExpander.

Additional context

If aws_route_table_expander_test.goNewAwsRouteTableExpander are removed, propagated routes need to be ignored, or perhaps propagated routes are the only routes that this middleware expands and hence hides from the user.

@n2N8Z n2N8Z added the kind/bug Something isn't working label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant