Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OSM-1038] nodejs plugin from cli with pnpm support #2

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

gemaxim
Copy link
Collaborator

@gemaxim gemaxim commented Apr 8, 2024

Moved functionality from https://github.com/snyk/cli/tree/main/src/lib/plugins/nodejs-plugin.
Added support for pnpm and pnpm workspaces.
Added minimal test cases.
On the first iteration, the cli will integrate this plugin only for pnpm support and pnpm workspaces support.

No circleci config for deployment yet.

JIRA ticket: https://snyksec.atlassian.net/browse/OSM-1038

@gemaxim gemaxim self-assigned this Apr 8, 2024
lib/npm-modules-parser.ts Outdated Show resolved Hide resolved
@gemaxim gemaxim force-pushed the feat/OSM-1038/nodejs-plugin-pnpm-support branch 6 times, most recently from bf6efd0 to e1af03a Compare April 11, 2024 12:27
@gemaxim gemaxim requested a review from a team as a code owner April 11, 2024 12:27
@gemaxim gemaxim force-pushed the feat/OSM-1038/nodejs-plugin-pnpm-support branch 8 times, most recently from 6033ea6 to ae6b93e Compare April 11, 2024 13:36
@gemaxim gemaxim closed this Apr 16, 2024
@gemaxim gemaxim reopened this Apr 16, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@gemaxim gemaxim force-pushed the feat/OSM-1038/nodejs-plugin-pnpm-support branch from ae6b93e to 3c563a6 Compare April 17, 2024 09:53
@gemaxim gemaxim requested a review from yurinka1 April 17, 2024 10:05
Copy link
Member

@JamesPatrickGill JamesPatrickGill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, I'm not sure if i missed it somewhere but do we have a test with a fixture that multiple types of workspace projects?

@gemaxim gemaxim force-pushed the feat/OSM-1038/nodejs-plugin-pnpm-support branch from 3c563a6 to 2ef8896 Compare April 17, 2024 13:40
@gemaxim gemaxim force-pushed the feat/OSM-1038/nodejs-plugin-pnpm-support branch from 2ef8896 to 4a3bd71 Compare April 17, 2024 13:43
@gemaxim gemaxim merged commit dc1be93 into main Apr 17, 2024
11 checks passed
@gemaxim gemaxim deleted the feat/OSM-1038/nodejs-plugin-pnpm-support branch April 17, 2024 13:49
@snyksec
Copy link

snyksec commented Apr 17, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants