-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [OSM-1038] nodejs plugin from cli with pnpm support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurinka1
reviewed
Apr 8, 2024
yurinka1
reviewed
Apr 8, 2024
yurinka1
reviewed
Apr 8, 2024
yurinka1
reviewed
Apr 8, 2024
yurinka1
reviewed
Apr 8, 2024
yurinka1
reviewed
Apr 8, 2024
yurinka1
reviewed
Apr 8, 2024
gemaxim
force-pushed
the
feat/OSM-1038/nodejs-plugin-pnpm-support
branch
6 times, most recently
from
April 11, 2024 12:27
bf6efd0
to
e1af03a
Compare
gemaxim
force-pushed
the
feat/OSM-1038/nodejs-plugin-pnpm-support
branch
8 times, most recently
from
April 11, 2024 13:36
6033ea6
to
ae6b93e
Compare
gemaxim
force-pushed
the
feat/OSM-1038/nodejs-plugin-pnpm-support
branch
from
April 17, 2024 09:53
ae6b93e
to
3c563a6
Compare
JamesPatrickGill
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, I'm not sure if i missed it somewhere but do we have a test with a fixture that multiple types of workspace projects?
gemaxim
force-pushed
the
feat/OSM-1038/nodejs-plugin-pnpm-support
branch
from
April 17, 2024 13:40
3c563a6
to
2ef8896
Compare
gemaxim
force-pushed
the
feat/OSM-1038/nodejs-plugin-pnpm-support
branch
from
April 17, 2024 13:43
2ef8896
to
4a3bd71
Compare
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved functionality from https://github.com/snyk/cli/tree/main/src/lib/plugins/nodejs-plugin.
Added support for pnpm and pnpm workspaces.
Added minimal test cases.
On the first iteration, the cli will integrate this plugin only for pnpm support and pnpm workspaces support.
No circleci config for deployment yet.
JIRA ticket: https://snyksec.atlassian.net/browse/OSM-1038