Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dropping the stdout traversal stuff #191

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: dropping the stdout traversal stuff #191

merged 1 commit into from
Nov 8, 2023

Conversation

dotkas
Copy link
Contributor

@dotkas dotkas commented Nov 8, 2023 •
edited
Loading

The previous v2 parsing logic did a whole bunch of over engineered magic to determine where the publish dir of the .dlls we need.

Just asking dotnet restore to define a --output should work a bit better 🤦🏻 .

@dotkas dotkas requested a review from a team as a code owner November 8, 2023 13:47
37IulianPopovici
37IulianPopovici approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@37IulianPopovici 37IulianPopovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotkas dotkas merged commit 9b7ca8c into main Nov 8, 2023
4 checks passed
@dotkas dotkas deleted the dotkas/harden-publish-dir-detection branch November 8, 2023 14:14
@snyksec
Copy link

snyksec commented Nov 9, 2023

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@37IulianPopovici 37IulianPopovici 37IulianPopovici approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotkas @snyksec @37IulianPopovici