feat: [SUP-2193] Runtime asembly gathering re-write for v2
parser
#193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the open beta is gaining traction, we've discovered some inconveniences in the way we gather the dependencies from
runtimepack
s that caused erroneous side-effects.The published list of
.deps.json
does not only contain assembly versions for the finished package, but also for any potential version that the .NET standard could encounter in a compatible environment, see this.As we were traversing the entire list of
target
s, that could mean that versions with the same name would be overwritten, defeating the purpose, ifSystem.Net.Http
was encountered multiple places with different versions.This rewrite now only looks for a specific
runtimepack
in the list oftargets
and returns only those versions, instead of everything.Technically a breaking change, but as its beta we'll keep the major intact, as this is bound to happen more times while we test the beta amongst our customers.
Change overview
netstandard
targets, as this will omitruntimepack
s by design, and will not produce an executable anyway in case of adotnet publish
, defating the purposeruntimepack
netstandard
test casesbin/
andobj/
folders from the test fixtures, as these are generated on the fly behind the scenes anyway and have no value to the tests