Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove isPublishable logic #212

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

andrei-cacio
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

the isPublishable was added to make better error messages for users who try to scan a project defined be not publishable.

However, this flag causes issues with older .NET versions. Will be removed until a better solution is in place.

@andrei-cacio andrei-cacio requested a review from a team as a code owner May 30, 2024 06:29
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@dotkas dotkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that one comment.

@andrei-cacio andrei-cacio force-pushed the fix/OSM-1754-remove-is-publishable branch from 045db18 to 004c0e3 Compare May 30, 2024 12:13
@andrei-cacio andrei-cacio merged commit 4272587 into main Jun 5, 2024
3 of 4 checks passed
@andrei-cacio andrei-cacio deleted the fix/OSM-1754-remove-is-publishable branch June 5, 2024 10:48
@snyksec
Copy link

snyksec commented Jun 5, 2024

🎉 This PR is included in version 2.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants