Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract validate test options #1697

Merged
merged 1 commit into from
Mar 9, 2021
Merged

feat: extract validate test options #1697

merged 1 commit into from
Mar 9, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Mar 8, 2021 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Extract snyk test option validation into a function so it can be easily re-used when needed across other commands.

@lili2311 lili2311 requested review from a team as code owners March 8, 2021 19:22
@lili2311 lili2311 self-assigned this Mar 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2021 •
edited by lili2311
Loading

Expected release notes (by @lili2311)

features:
extract validate test options (e091054)

others (will not be included in Semantic-Release notes):
generate snyk test error (4e9ef13)
validateCredentials token check (c9bafa6)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2021

Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against e091054

@lili2311 lili2311 merged commit f5786bf into master Mar 9, 2021
@lili2311 lili2311 deleted the feat/validate-test-options branch March 9, 2021 09:54
This was referenced Mar 9, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackuB JackuB JackuB approved these changes

Assignees

@lili2311 lili2311

Labels
🐂 Team Bull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lili2311 @JackuB