Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop unused pinningSupported calculation #1701

Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix: drop unused pinningSupported calculation #1701

merged 1 commit into from
Mar 9, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Mar 9, 2021 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Drop unused pinningSupported property calculation + type the scan result options array

@lili2311 lili2311 self-assigned this Mar 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021 •
edited by lili2311
Loading

Expected release notes (by @lili2311)

fixes:
drop unused pinningSupported calculation (56558b1)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lili2311 lili2311 marked this pull request as ready for review March 9, 2021 12:51
@lili2311 lili2311 requested review from a team as code owners March 9, 2021 12:51
anthogez
anthogez approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@anthogez anthogez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@lili2311 lili2311 merged commit cd3fd33 into master Mar 9, 2021
@lili2311 lili2311 deleted the fix/remove-unused-pinning-code branch March 9, 2021 13:41
This was referenced Mar 9, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthogez anthogez anthogez approved these changes

Assignees

@lili2311 lili2311

Labels
🐂 Team Bull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lili2311 @anthogez