Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LINK-699] feat: sbom maven & gradle extra args support #4819

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

danlucian
Copy link
Member

@danlucian danlucian commented Aug 31, 2023

What does this PR do?

Add support for the following args for the snyk sbom command:

maven:

  • --maven-aggregate-project
  • --scan-unmanaged --file=<JAR_FILE_NAME>
  • --scan-all-unmanaged

gradle:

  • --sub-project=<NAME>, --gradle-sub-project=<NAME>
  • --all-sub-projects
  • --configuration-matching=<CONFIGURATION_REGEX>
  • --configuration-attributes=<ATTRIBUTE>[,<ATTRIBUTE>]...
  • --init-script=<FILE>

@danlucian danlucian requested a review from a team as a code owner August 31, 2023 11:48
@bastiandoetsch
Copy link
Contributor

bastiandoetsch commented Aug 31, 2023

Hey @danlucian, would you mind adding Acceptance Tests for the additional parameters, so that the integration into the CLI is tested sufficiently?

@klesniewski klesniewski requested a review from a team as a code owner August 31, 2023 15:40
@klesniewski klesniewski force-pushed the feat/sbom-maven-gradle-extra-args-support branch 4 times, most recently from fb86985 to 585ef20 Compare September 1, 2023 14:01
@danlucian danlucian force-pushed the feat/sbom-maven-gradle-extra-args-support branch from 5f5883e to b3d1142 Compare September 4, 2023 07:38
@danlucian danlucian changed the title feat: sbom maven & gradle extra args support [LINK-699] feat: sbom maven & gradle extra args support Sep 4, 2023
@danlucian danlucian force-pushed the feat/sbom-maven-gradle-extra-args-support branch from b3d1142 to 01bc881 Compare September 4, 2023 08:40
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Add support for the following args for the snyk sbom command:

maven:
--maven-aggregate-project
--scan-unmanaged --file=<JAR_FILE_NAME>
--scan-all-unmanaged

gradle:
--sub-project=<NAME>, --gradle-sub-project=<NAME>
--all-sub-projects
--configuration-matching=<CONFIGURATION_REGEX>
--configuration-attributes=<ATTRIBUTE>[,<ATTRIBUTE>]...
--init-script=<FILE>

Co-authored-by: Krzysztof <krzysztof.lesniewski@snyk.io>
@danlucian danlucian force-pushed the feat/sbom-maven-gradle-extra-args-support branch from 01bc881 to 5e5983a Compare September 4, 2023 10:50
@topaztee
Copy link

topaztee commented Sep 4, 2023

Why not also update https://github.com/snyk/cli/blob/ff6575ec180d59528f51e98148fe151471b161c5/help/cli-commands/sbom.md
so users will be able to see the newly available commands through snyk sbom --help

@topaztee
Copy link

topaztee commented Sep 4, 2023

Why not also update https://github.com/snyk/cli/blob/ff6575ec180d59528f51e98148fe151471b161c5/help/cli-commands/sbom.md so users will be able to see the newly available commands through snyk sbom --help

scratch that, @danlucian informed me its done via gitbooks

@danlucian danlucian merged commit 3ebe046 into master Sep 4, 2023
@danlucian danlucian deleted the feat/sbom-maven-gradle-extra-args-support branch September 4, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants