Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump language server protocol version to 11 [IDE-236] #5156

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

bastiandoetsch
Copy link
Contributor

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

What does this PR do?

This PR updates the included language server to protocol version 11.

🚨This guards & enforces an API change for IDE clients that is needed for global ignores. This version and consecutive versions of the CLI will only be downloaded from IDEs that have require the same protocol version. Older IDE plugins will stay on the previous CLI.

Risk: Low

Where should the reviewer start?

Snyk-LS, go-releaser.yaml

How should this be manually tested?

make build should display protocol version 11, the corresponding file (ls-protocol-version-11) in binary-releases should be generated.

Any background context you want to provide?

Protocol version 11 is going to be required for global ignores, as it uses a new API call to retrieve feature flags, that is used and exposed as an LSP command. This command is NOT available in version 10, thus the update.

What are the relevant tickets?

IDE-236

Screenshots

Additional questions

This safe-guards and enforces that global ignores functionality has the necessary commands available.
@bastiandoetsch bastiandoetsch merged commit fc41937 into main Apr 9, 2024
15 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-236_bump_ls_protocol_version branch April 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants