-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump language server protocol version to 11 [IDE-236] #5156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This safe-guards and enforces that global ignores functionality has the necessary commands available.
4 tasks
thisislawatts
approved these changes
Apr 9, 2024
This was referenced Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.What does this PR do?
This PR updates the included language server to protocol version 11.
🚨This guards & enforces an API change for IDE clients that is needed for global ignores. This version and consecutive versions of the CLI will only be downloaded from IDEs that have require the same protocol version. Older IDE plugins will stay on the previous CLI.
Risk: Low
Where should the reviewer start?
Snyk-LS, go-releaser.yaml
How should this be manually tested?
make build
should display protocol version 11, the corresponding file (ls-protocol-version-11
) inbinary-releases
should be generated.Any background context you want to provide?
Protocol version 11 is going to be required for global ignores, as it uses a new API call to retrieve feature flags, that is used and exposed as an LSP command. This command is NOT available in version 10, thus the update.
What are the relevant tickets?
IDE-236
Screenshots
Additional questions